Assertion error does not state problematic parts for Maps

[pcorpet]

chai.expect(new Map([['a','a']])).to.deep.equal(new Map([['a','b']]))
// AssertionError: expected {} to deeply equal {}

As you can see it is not clear why it fails from the error message.

[keithamus]

Thanks for this @pcorpet but we're very close to releasing a new version of the inspection engine: chaijs/loupe#14.

Once we get loupe@2 out we'll be updating Chai to use it, and it will replace all inspect code.

We really appreciate the work you've done here! I hope in closing this PR we don't dissuade you from making further contributions!

[pcorpet]

Hi @keithamus thanks for the update. As the bug is still there, can you keep the issue open, and close the PR instead?

[keithamus]

Oops I thought I did that, sorry!

[Hocdoc]

Will there be a solution for this issue in the next months?

[keithamus]

chaijs/loupe#14 was merged, but the build is failing and needs some general maintainence to get it ready for a proper 2.0. I'm very short on free time so unable to pick this up right now, but perhaps I might find time in the next few months. Once loupe@2 is released it can be upgraded in chai and we can release a new version of that.

If anyone wants to help out, investigating build failures in loupe and submitting a PR to fix them would be a great start!

[pcorpet]

It seems that Loupe v2 is out, what's the next step @keithamus ?

[keithamus]

The next step would be to somehow integrate it into the 4.x branch. It might be worth first adding it to the main branch - which will allow for breaking changes - then we can assess what breakages need to be smoothed over for 4.x

[flaambe]

I tried to integrate the loup into chai, but unfortunately now I do not have enough time for this

[pcorpet]

I've created a PR, please help me there to understand which changes are OK, and which ones are not

[pcorpet]

This is not way better now, if I introduce only one change in one value:

AssertionError: expected Map{ …(17) } to deeply equal Map{ …(17) }

Any idea how to fix?