Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error message for Map #1229

Closed
wants to merge 1 commit into from
Closed

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Jan 22, 2019

Closes #1228

@pcorpet pcorpet requested a review from a team as a code owner January 22, 2019 08:44
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #1229 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
+ Coverage   94.51%   94.53%   +0.02%     
==========================================
  Files          32       32              
  Lines        1676     1684       +8     
  Branches      404      407       +3     
==========================================
+ Hits         1584     1592       +8     
  Misses         92       92
Impacted Files Coverage Δ
lib/chai/utils/inspect.js 82.9% <100%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cededa...c8c58a7. Read the comment docs.

@keithamus keithamus closed this Jan 22, 2019
@keithamus
Copy link
Member

Thanks for this @pcorpet but we're very close to releasing a new version of the inspection engine: chaijs/loupe#14.

Once we get loupe@2 out we'll be updating Chai to use it, and it will replace all inspect code.

We really appreciate the work you've done here! I hope in closing this PR we don't dissuade you from making further contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants