Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

above and below should be available on assert #305

Closed
timruffles opened this issue Nov 12, 2014 · 2 comments · Fixed by #311
Closed

above and below should be available on assert #305

timruffles opened this issue Nov 12, 2014 · 2 comments · Fixed by #311
Labels
medium-size pull-request-wanted

Comments

@timruffles
Copy link
Member

Unsure why there are methods on expect syntax that aren't on the assert one. Seems to violate principle of least surprise: they should be alternative syntaxes, not slightly different libraries.

I'm happy to write the PR :)
@vesln
Copy link
Member

vesln commented Nov 12, 2014

Happy to merge it in!

@keithamus
Copy link
Member

@timruffles it'd be great to see a PR for this. Plus you'd get some great credits in our contributors graph for it 😄.

lexi-sh pushed a commit to lexi-sh/chai that referenced this issue Nov 29, 2014
Issue chaijs#305 fixed, added assert.isAbove and assert.isBelow
e8e8caf
@lexi-sh lexi-sh mentioned this issue Nov 29, 2014
Merged
keithamus added a commit that referenced this issue Dec 2, 2014
@keithamus
Merge pull request #311 from cjqed/305-above-below-on-assert
49e003c 
Issue #305 fixed, added assert.isAbove and assert.isBelow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium-size pull-request-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #305 fixed, added assert.isAbove and assert.isBelow lexi-sh/chai
3 participants
@keithamus @timruffles @vesln