Issue #305 fixed, added assert.isAbove and assert.isBelow #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty great to me - with tests too ❤️! I'll wait for @logicalparadox's approval before merging though. |
|
@vesln or @logicalparadox, you happy to see this merged in? |
|
👍 |
keithamus
added a commit
that referenced
this pull request
Dec 2, 2014
Issue #305 fixed, added assert.isAbove and assert.isBelow
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #305 , and adds the
isAboveandisBelowfunctions on assert. All the tests ran fine for me on my machine, let me know if I messed anything (like public api comments) up or if something doesn't look right.Thanks!