-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite fails on IE9 #66
Comments
@rosenfeld - I am assuming you are referring to the @domenic - Can you confirm what is and is not working? Also, should be do a browser expectations table on the top of the tests perhaps? |
Hi @logicalparadox, sorry, I can't remember, I had just followed the link in my wife's notebook but I have already turned it off long ago, but it should be easy to replicate this if you have IE9 ;) |
OK, so, we have some new problems, sadly. In addition to Disregarding
These generally occur because of use of The only solution I could see would be to, instead of using |
Oh dammit functions in IE10 have a non-configurable |
OK I can get the above tests passing, excluding (for some reason) "Assertion.includeStack is false," with the following diff: var asserterNames = Object.getOwnPropertyNames(Assertion.prototype);
asserterNames.forEach(function (asserterName) {
if (asserterName === "arguments" || asserterName === "length") { return; }
var propertyDescriptor = Object.getOwnPropertyDescriptor(Assertion.prototype, asserterName);
Object.defineProperty(assert, asserterName, propertyDescriptor);
});
assert.__flags = this.__flags; // i guess i'd update to use `getAllFlags` nowadays.
//assert.__proto__ = this; The expect([1, 2, 3]).to.have.a.length(5) would break. But I just tested and that doesn't work in other browsers even with |
It seems Microsoft won't allow non-registered users to see their bugs... :( I wonder what is the reason for that policy... |
This will help more directly with #66 and with chaijs/chai-as-promised#5.
@domenic 's changes have been merged into release 1.0.2 so we are back to the expected IE support. |
…ijs#66) * Adding compare function to be used in expected object template * Adding compare function example to README.md
…ijs#66) * Adding compare function to be used in expected object template * Adding compare function example to README.md
Official documentation points to an online suite that doesn't seem to exist:
http://chaijs.com/guide/installation/
Points to:
http://chaijs.com/support/tests/
I found this working link:
http://chaijs.com/api/test/
And it fails on IE9.
The text was updated successfully, but these errors were encountered: