Chaining and flags #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help more directly with #66 and with chaijs/chai-as-promised#5.
Uses `transferFlags`, and will be used for Chai's `a`/`an` and `includes`/`contains`.
Expect and assert tests now pass in IE9, IE10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New utility
transferFlagsreplacesgetAllFlags. Will be useful for chaijs/chai-as-promised#5 and is used in fixing #66.New utility
addChainableMethod. Encapsulates the transfer of prototype properties and flags onto new function objects, which are returned from getters... yeah, you know. It's basically the pattern we often do, except using manual proto-property and flag transfer instead of__proto__.Used
addChainableMethodona/anandincludes/contains, which (after a browser build) makes the expect and assert tests pass again in IE9/IE10.Please code review! :)