Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New showDiff behaviour also depending on expected and actual values #574

Merged
merged 1 commit into from
Dec 20, 2015

Conversation

lucasfcosta
Copy link
Member

This is related to the #515 issue.

I've used try/catch blocks on the test because adding a new parameter to the err() function seems too ugly.

I'm also directly using chai.Assertion because this way we guarantee this test won't be too tightly coupled with other assertion methods implementation.

PS.: Thank you guys for the awesome work you've been doing on Chai.

@keithamus
Copy link
Member

Thanks for the awesome work @lucasfcosta 😄

keithamus added a commit that referenced this pull request Dec 20, 2015
New showDiff behaviour also depending on expected and actual values
@keithamus keithamus merged commit 2583873 into chaijs:4.x.x Dec 20, 2015
@meeber meeber mentioned this pull request May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants