Enabling showDiff for assert's equal and notEqual methods. Closes #790 #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to close #790.
As explained on this post the
equal
andnotEqual
methods on theassert
interface, which calledAssertion.assert
directly, didn't have theshowDiff
flag turned on and that would make their error messages look different because of the way the test runner showed results.In order to make that behavior consistent with the
equal
related methods on other interfaces, I enabled theshowDiff
flag for these assertions too.I didn't add any tests since this was a problem related to the test runner and not ours.
Please read the post I linked above for more details.
Thanks everyone 😄