Fix spend logic for unlock deposit amount #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VjeraTurk
reviewed
Feb 11, 2025
| @@ -1443,7 +1445,7 @@ export class Builder { | |||
| changeThreshold | |||
| ) | |||
|
|
|||
| aad.addAssetAmount(feeAssetID, zero, fee) | |||
| aad.addAssetAmount(feeAssetID, amountToUnlock, fee) | |||
|
|
|||
| const minSpendableErr: Error = await this.spender.getMinimumSpendable( | |||
There was a problem hiding this comment.
- call spend for burning the already unlocked UTXOs
- call a call to a different function (undeposit ) to unlock the locked UTXOs
VjeraTurk
reviewed
Feb 11, 2025
| * @param changeThreshold Optional. The number of signatures required to spend the funds in the resultant change UTXO | ||
| * | ||
| * @returns An unsigned transaction created from the passed in parameters. | ||
| */ | ||
| buildUnlockDepositTx = async ( | ||
| utxoset: UTXOSet, | ||
| fromAddresses: string[], | ||
| fromAddresses: FromType, |
There was a problem hiding this comment.
Instead of fromAdresses we need depositTxIDs (better than depositOfferId)
We skip the amount for now
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of api buildUnlockDepositTx by converting fromAddresses to commonly used
FromTypeand adds the argumentamountToUnlockin the builder function to consider it when constructing in/output utxos by calling the node spend logic.