forked from ava-labs/avalanchejs
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spend logic for unlock deposit amount #86
Open
knikos
wants to merge
1
commit into
dev
Choose a base branch
from
bugfix/unlock-deposit-tx-amount
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1415,6 +1415,7 @@ export class Builder { | |
* @param feeAssetID Optional. The assetID of the fees being burned | ||
* @param memo Optional contains arbitrary bytes, up to 256 bytes | ||
* @param asOf Optional. The timestamp to verify the transaction against as a {@link https://github.com/indutny/bn.js/|BN} | ||
* @param amountToUnlock The amount of tokens to unlock | ||
* @param changeThreshold Optional. The number of signatures required to spend the funds in the resultant change UTXO | ||
* | ||
* @returns An unsigned UnlockDepositTx created from the passed in parameters. | ||
|
@@ -1428,6 +1429,7 @@ export class Builder { | |
feeAssetID: Buffer = undefined, | ||
memo: Buffer = undefined, | ||
asOf: BN = zero, | ||
amountToUnlock: BN, | ||
changeThreshold: number = 1 | ||
): Promise<UnsignedTx> => { | ||
let ins: TransferableInput[] = [] | ||
|
@@ -1443,7 +1445,7 @@ export class Builder { | |
changeThreshold | ||
) | ||
|
||
aad.addAssetAmount(feeAssetID, zero, fee) | ||
aad.addAssetAmount(feeAssetID, amountToUnlock, fee) | ||
|
||
const minSpendableErr: Error = await this.spender.getMinimumSpendable( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
aad, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of fromAdresses we need depositTxIDs (better than depositOfferId)
We skip the amount for now