This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
fix newest-file selection for offline cache #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Issue discovered while using https://github.com/chainguard-dev/rules_apko)
Given the following keyrings:
the following directory structure is created:
This is fine when looking for the public key file for https://packages.sgdev.org/chainguard/chainguard-enterprise.rsa.pub, but may fail for https://packages.sgdev.org/sourcegraph-melange-prod.rsa.pub if the directory
chainguard/
has a newer timestamp than the public key file (I was not able to reproduce this locally on darwin, but reliably on linux CI machines).This PR addresses this by not selecting directories as possible "newest" dir entries.