K8s runner retry exec #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
k8s-runner-retry-exec
branch
from
80f7a01 to
e816baa
Compare
joshrwolf
force-pushed
the
k8s-runner-retry-exec
branch
2 times, most recently
from
e79e393 to
ce1e2a8
Compare
imjasonh
previously approved these changes
Jul 17, 2023
Signed-off-by: Josh Wolf <josh@wolfs.io>
joshrwolf
force-pushed
the
k8s-runner-retry-exec
branch
from
ce1e2a8 to
6d641e1
Compare
imjasonh
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a class of flakes that appear when trying to run a remote command (
k exec) in a pod that isn't ready to receive requests yet.the most common example we've seen is on gke autopilot, where nodes can scale up all the way to pod
Running, but not have a healthy networking backplane yet (anetdis still spinning), resulting in a flake that looks like:this ensures we retry everything that isn't an actual build error, up to 4 times