Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s runner retry exec #549

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

joshrwolf
Copy link
Contributor

this fixes a class of flakes that appear when trying to run a remote command (k exec) in a pod that isn't ready to receive requests yet.

the most common example we've seen is on gke autopilot, where nodes can scale up all the way to pod Running, but not have a healthy networking backplane yet (anetd is still spinning), resulting in a flake that looks like:

2023/07/16 05:58:08 error during command execution: failed to build package: unable to run pipeline: running remote command: failed to run remote command: error dialing backend: No agent available

this ensures we retry everything that isn't an actual build error, up to 4 times

@joshrwolf joshrwolf marked this pull request as ready for review July 17, 2023 13:08
@joshrwolf joshrwolf requested a review from a team as a code owner July 17, 2023 13:08
@joshrwolf joshrwolf requested review from luhring and removed request for a team July 17, 2023 13:08
@joshrwolf joshrwolf force-pushed the k8s-runner-retry-exec branch 2 times, most recently from e79e393 to ce1e2a8 Compare July 17, 2023 13:09
imjasonh
imjasonh previously approved these changes Jul 17, 2023
Signed-off-by: Josh Wolf <josh@wolfs.io>
@joshrwolf joshrwolf merged commit 2f63ca5 into chainguard-dev:main Jul 17, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants