K8s runner various fixes #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Wolf <josh@wolfs.io>
Signed-off-by: Josh Wolf <josh@wolfs.io>
imjasonh
approved these changes
Jul 12, 2023
| return fmt.Errorf("failed to create remote command executor: %v", err) | ||
| } | ||
|
|
||
| return exec.StreamWithContext(context.Background(), remotecommand.StreamOptions{ |
There was a problem hiding this comment.
Please propagate context 🙏
There was a problem hiding this comment.
I missed this thanks! this also made me realize I missed passing the actual retry 🤯
will refactor things slightly to make sure context is passed while still implementing io.Reader
kaniini
reviewed
Jul 12, 2023
| } | ||
|
|
||
| // TODO: The primary caller of this function is the KubernetesRunner, which | ||
| // uses the busybox variant of `tar` that doesn't support xattrs. So this |
There was a problem hiding this comment.
Could we not make it use libarchive-tools instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds some low hanging fruit bug fixes / qol improvements isolated to the k8s runner:
bug fixes:
pkg.Emit()qol:
kubectl cp)