Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s runner fetch workspace tgz #551

Merged
merged 1 commit into from
Jul 20, 2023
Merged

K8s runner fetch workspace tgz #551

merged 1 commit into from
Jul 20, 2023

Conversation

joshrwolf
Copy link
Contributor

  • changes the workspace fetcher to use a tgz stream instead
  • adds a retryable workspace fetcher for the k8s runner. this was a significant source of flakes that is mostly eliminated now
  • updates the other runners that use workspace fetcher to use tgz (lima)

@joshrwolf joshrwolf force-pushed the k8s-runner-fetch-workspace-tgz branch 2 times, most recently from ed97f33 to 9d9c04c Compare July 17, 2023 12:59
@joshrwolf
Copy link
Contributor Author

keeping this in draft until #548 lands

@joshrwolf joshrwolf force-pushed the k8s-runner-fetch-workspace-tgz branch from 9d9c04c to 109076a Compare July 17, 2023 13:04
@joshrwolf joshrwolf mentioned this pull request Jul 17, 2023
Closed
@joshrwolf joshrwolf force-pushed the k8s-runner-fetch-workspace-tgz branch 4 times, most recently from 9c2779d to 8377458 Compare July 18, 2023 20:07
@joshrwolf
add a retryable (tgz) fetcher for the k8s runner
3a071d5 
Signed-off-by: Josh Wolf <josh@wolfs.io>
@joshrwolf joshrwolf force-pushed the k8s-runner-fetch-workspace-tgz branch from 8377458 to 3a071d5 Compare July 20, 2023 00:23
@joshrwolf joshrwolf marked this pull request as ready for review July 20, 2023 21:50
@joshrwolf joshrwolf requested a review from a team as a code owner July 20, 2023 21:50
@joshrwolf joshrwolf requested review from rawlingsj and removed request for a team July 20, 2023 21:50
@kaniini kaniini merged commit 8a6dd3a into chainguard-dev:main Jul 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

@rawlingsj rawlingsj Awaiting requested review from rawlingsj rawlingsj was automatically assigned from chainguard-dev/images-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshrwolf @mattmoor @kaniini