use go-apk.FullFS for retrieving builder workspaces #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting this out of #545 because it changes the signature of
RetrieveWorkspace.This primarily fixes the kubernetes runner not fetching the full contents of the post-build workspace, which resulted in invalid and mismatched apk's vs the other local runners.
Since this is now really just doing an untar using
apkofs.FullFS, I think there's merit to moving this out ofmelangeand intogo-apk(maybetarball.Untar()? Say the word and I'll be happy to move it there