Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s runner template bugs #550

Merged
merged 1 commit into from
Jul 17, 2023
Merged

K8s runner template bugs #550

merged 1 commit into from
Jul 17, 2023

Conversation

joshrwolf
Copy link
Contributor

  • ensures the workspace environment variables are passed to the builder pod
  • properly allow user defined volumes and volumeMounts to be set so that they don't override the melange provided ones

@joshrwolf
properly pass workspace env/volumes to k8s builder pods
1b061a7 
Signed-off-by: Josh Wolf <josh@wolfs.io>
@joshrwolf joshrwolf force-pushed the k8s-runner-template-bugs branch from 68219fa to 1b061a7 Compare July 17, 2023 13:01
@joshrwolf joshrwolf marked this pull request as ready for review July 17, 2023 13:05
@joshrwolf joshrwolf requested a review from a team as a code owner July 17, 2023 13:05
@joshrwolf joshrwolf requested review from kaniini and removed request for a team July 17, 2023 13:05
@joshrwolf joshrwolf mentioned this pull request Jul 17, 2023
Closed
@joshrwolf joshrwolf merged commit e4b6ff6 into chainguard-dev:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

@kaniini kaniini Awaiting requested review from kaniini kaniini was automatically assigned from chainguard-dev/images-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshrwolf @imjasonh