Allow vendored pkgconfig deps #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird: wolfi-dev/os#11326 |
Some packages vendor multiple versions of the same dependency. For example, neon contains several version of postgres. These versions each had a pkgconfig directory that provided different versions of the same thing. These overlapping provides cause apk to fail when trying to install it. Also fix presubmit that broke due to change in wolfi-dev/os. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
jonjohnsonjr
force-pushed
the
more-vendor
branch
from
a581486 to
8d9a632
Compare
|
Is this something we can add a test for? 🙏 |
Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
imjasonh
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages vendor multiple versions of the same dependency. For example, neon contains several version of postgres. These versions each had a pkgconfig directory that provided different versions of the same thing. These overlapping provides cause apk to fail when trying to install it.