Don't use [[ in Makefile #11326
Merged
Don't use [[ in Makefile #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The melange presubmit runs in an ubuntu container which doesn't seem to contain the [[ binary but does contain the [ binary. This is all very silly but I think this makes the Makefile slightly more portable. I don't understand how computers work. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
imjasonh
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The melange presubmit runs in an ubuntu container which doesn't seem to contain the [[ binary but does contain the [ binary. This is all very silly but I think this makes the Makefile slightly more portable. I don't understand how computers work.
Failed presubmit: https://github.com/chainguard-dev/melange/actions/runs/7563217425/job/20595293572?pr=935
Relevant logs: