Handle multi runtime properly #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuchengxu
added a commit
that referenced
this pull request
Feb 4, 2021
* Enable clippy check * Revert clippy check * Remove CC1 (#446) * Bump 2.0.8-1 (#449) * Update Substrate to bb0fb2965f9eb59c305ce0c294962d3317a29ece but incomplete, basically make it compile, there are still some FIXMEs and TODOs. * Fix format * Fix test compile * Remove debugging print * Workaround for a potential Substrate glitch * Add malan runtime (#463) * ChainX TC0 * Update btc testnet header * Use Testnet in xpallet-system * Add ptc0 chain * Bump spec version to 7 * Fast governance processure * Add malan runtime * Add malan.json * Rename chainx-dev-runtime to dev-runtime * Use dns in bootnode * Fix clippy under runtime-benchmarks feature * Update error message for invalid chain option * Add two more malan bootnodes * Rebuild malan genesis config * Update btc genesis * Use new manlan config * Update malan.json * Use new malan.json * Rebuild malan runtime Since we currently has only one executor(`chainx`), we must use spec_name = "chainx" in the runtime code. * Update malan.json * Use malan.json * Clean up unused code * Revert chainx.json changes * Fix malan runtime build * Add btc_2.0.json * Handle multi runtime properly (#473) * Handle multi runtime properly * Split out service crate * Run cargo fmt * Reenable new_light() * Split out service/client.rs * Cargo fmt * Clean up
liuchengxu
added a commit
that referenced
this pull request
Feb 6, 2021
* Enable clippy check * Revert clippy check * Remove CC1 (#446) * Bump 2.0.8-1 (#449) * Update Substrate to bb0fb2965f9eb59c305ce0c294962d3317a29ece but incomplete, basically make it compile, there are still some FIXMEs and TODOs. * Fix format * Fix test compile * Remove debugging print * Workaround for a potential Substrate glitch * Add malan runtime (#463) * ChainX TC0 * Update btc testnet header * Use Testnet in xpallet-system * Add ptc0 chain * Bump spec version to 7 * Fast governance processure * Add malan runtime * Add malan.json * Rename chainx-dev-runtime to dev-runtime * Use dns in bootnode * Fix clippy under runtime-benchmarks feature * Update error message for invalid chain option * Add two more malan bootnodes * Rebuild malan genesis config * Update btc genesis * Use new manlan config * Update malan.json * Use new malan.json * Rebuild malan runtime Since we currently has only one executor(`chainx`), we must use spec_name = "chainx" in the runtime code. * Update malan.json * Use malan.json * Clean up unused code * Revert chainx.json changes * Fix malan runtime build * Add btc_2.0.json * Handle multi runtime properly (#473) * Handle multi runtime properly * Split out service crate * Run cargo fmt * Reenable new_light() * Split out service/client.rs * Cargo fmt * Clean up * Update Substrate to 93b231e79f5b4e551c34234e89fa4a2e5e9c1510 * Remove tmp btc_2.0.json * Update Substrate to 81ca765646c35c7676ec2f86e718bf1f6a5cc274 * Update Substrate to bc69520ae4abb78ca89a57ff9af8887d598ce048 * Update Substrate to 075796f75f754a712ebb417c8b17633f7b88adf1 * Update Substrate to f14488dfca012659297d2b4676fab91c179095dd * Fix test * Fix todo! with current impl * Fix fmt * Fix btc v2 mock
liuchengxu
added a commit
that referenced
this pull request
Mar 18, 2021
* Enable clippy check * Revert clippy check * Remove CC1 (#446) * Bump 2.0.8-1 (#449) * Update Substrate to bb0fb2965f9eb59c305ce0c294962d3317a29ece but incomplete, basically make it compile, there are still some FIXMEs and TODOs. * Fix format * Fix test compile * Remove debugging print * Workaround for a potential Substrate glitch * Add malan runtime (#463) * ChainX TC0 * Update btc testnet header * Use Testnet in xpallet-system * Add ptc0 chain * Bump spec version to 7 * Fast governance processure * Add malan runtime * Add malan.json * Rename chainx-dev-runtime to dev-runtime * Use dns in bootnode * Fix clippy under runtime-benchmarks feature * Update error message for invalid chain option * Add two more malan bootnodes * Rebuild malan genesis config * Update btc genesis * Use new manlan config * Update malan.json * Use new malan.json * Rebuild malan runtime Since we currently has only one executor(`chainx`), we must use spec_name = "chainx" in the runtime code. * Update malan.json * Use malan.json * Clean up unused code * Revert chainx.json changes * Fix malan runtime build * Add btc_2.0.json * Handle multi runtime properly (#473) * Handle multi runtime properly * Split out service crate * Run cargo fmt * Reenable new_light() * Split out service/client.rs * Cargo fmt * Clean up * Update Substrate to 93b231e79f5b4e551c34234e89fa4a2e5e9c1510 * Remove tmp btc_2.0.json * Update Substrate to 81ca765646c35c7676ec2f86e718bf1f6a5cc274 * Update Substrate to bc69520ae4abb78ca89a57ff9af8887d598ce048 * Update Substrate to 075796f75f754a712ebb417c8b17633f7b88adf1 * Update Substrate to f14488dfca012659297d2b4676fab91c179095dd * Fix test * Fix todo! with current impl * Update Substrate to 3.0.0 * MIgrate assets-registrar test to construct_runtime! * Migrate xpallet_assets test to construct_runtime! * Migrate all tests to construct_runtime! * Update orml-* to 0.4.0 * Remove patches in Cargo.toml * Impl ReportLongevity properly * Cargo fmt * Reset malan (#479) * Add Proxy module (#478) * Add Proxy module * Cargo fmt * Bump spec version * Update to the latest master of Substrate Ref paritytech/substrate#8117 * Fix wrong feature gate on grandpa after splitting out service crate * Cargo fmt * Replace sc-finality-grandpa-wrap-sync git dep using crates.io dep
liuchengxu
added a commit
that referenced
this pull request
Mar 19, 2021
* Fix wrong feature gate about grandpa in service * Update btc bridge 2.0 to Substrate 3.0.0 (#509) * Enable clippy check * Revert clippy check * Remove CC1 (#446) * Bump 2.0.8-1 (#449) * Update Substrate to bb0fb2965f9eb59c305ce0c294962d3317a29ece but incomplete, basically make it compile, there are still some FIXMEs and TODOs. * Fix format * Fix test compile * Remove debugging print * Workaround for a potential Substrate glitch * Add malan runtime (#463) * ChainX TC0 * Update btc testnet header * Use Testnet in xpallet-system * Add ptc0 chain * Bump spec version to 7 * Fast governance processure * Add malan runtime * Add malan.json * Rename chainx-dev-runtime to dev-runtime * Use dns in bootnode * Fix clippy under runtime-benchmarks feature * Update error message for invalid chain option * Add two more malan bootnodes * Rebuild malan genesis config * Update btc genesis * Use new manlan config * Update malan.json * Use new malan.json * Rebuild malan runtime Since we currently has only one executor(`chainx`), we must use spec_name = "chainx" in the runtime code. * Update malan.json * Use malan.json * Clean up unused code * Revert chainx.json changes * Fix malan runtime build * Add btc_2.0.json * Handle multi runtime properly (#473) * Handle multi runtime properly * Split out service crate * Run cargo fmt * Reenable new_light() * Split out service/client.rs * Cargo fmt * Clean up * Update Substrate to 93b231e79f5b4e551c34234e89fa4a2e5e9c1510 * Remove tmp btc_2.0.json * Update Substrate to 81ca765646c35c7676ec2f86e718bf1f6a5cc274 * Update Substrate to bc69520ae4abb78ca89a57ff9af8887d598ce048 * Update Substrate to 075796f75f754a712ebb417c8b17633f7b88adf1 * Update Substrate to f14488dfca012659297d2b4676fab91c179095dd * Fix test * Fix todo! with current impl * Update Substrate to 3.0.0 * MIgrate assets-registrar test to construct_runtime! * Migrate xpallet_assets test to construct_runtime! * Migrate all tests to construct_runtime! * Update orml-* to 0.4.0 * Remove patches in Cargo.toml * Impl ReportLongevity properly * Cargo fmt * Reset malan (#479) * Add Proxy module (#478) * Add Proxy module * Cargo fmt * Bump spec version * Update to the latest master of Substrate Ref paritytech/substrate#8117 * Fix wrong feature gate on grandpa after splitting out service crate * Cargo fmt * Replace sc-finality-grandpa-wrap-sync git dep using crates.io dep * Cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have multiple runtimes but actually have one service that uses
chainx_runtimeonly which is problematic when these runtimes are incompatible. This PR ensures eachchainuses the right runtime and executor.