Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Object.getOwnPropertyDescriptors with spec changes #1342

Closed
ljharb opened this issue Jul 26, 2016 · 4 comments
Closed

Update Object.getOwnPropertyDescriptors with spec changes #1342

ljharb opened this issue Jul 26, 2016 · 4 comments
Labels
ES Spec Changed Fixed

Comments

@ljharb
Copy link
Collaborator

ljharb commented Jul 26, 2016 •
edited
Loading

Per tc39/ecma262#593 - if the result of [[GetOwnPropertyDescriptor]] is undefined, it should not be stored on the returned descriptors object.
@ljharb ljharb mentioned this issue Jul 26, 2016
Merged
@ianwjhalliday
Copy link
Collaborator

it should not not be stored

@ljharb double not intentional or typo? That is to clarify, you are saying it should be stored on the returned descriptors object?

fyi @jordonwii

@ljharb
Copy link
Collaborator Author

ljharb commented Jul 26, 2016

Typo, sorry - updated.

undefined descriptors must not be present on the return of Object.getOwnPropertyDescriptors.

@ianwjhalliday
Copy link
Collaborator

@ljharb cool

@jordonwii want to take this?

@j-wing
Copy link
Contributor

j-wing commented Jul 26, 2016

@ianwjhalliday Yep - it should be a straightforward change.

@j-wing j-wing mentioned this issue Jul 27, 2016
Merged
chakrabot pushed a commit that referenced this issue Jul 29, 2016
[MERGE #1345 @jordonwii] Only add defined properties to the result of…
0a0d256 
… getOwnPropertyDescriptors

Merge pull request #1345 from jordonwii:issue1342

Fixes #1342

For the tests for this change, I adapted @ljharb's tests from the discussion he linked to in the issue and trimmed it down to test just this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ES Spec Changed Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @j-wing @ianwjhalliday