Normative: Object.getOwnPropertyDescriptors should not create keys for undefined descriptors
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for undefined descriptors. Per discussion on tc39#582 (comment)
bterlson
added
the
needs consensus
ljharb
added a commit
to tc39/agendas
that referenced
this pull request
Jun 2, 2016
|
It's also good to check the current behavior on runtimes. Would you like to feed test262 with a few assertions for this change? |
|
@leobalter sure, i'll put up a PR to test262 as well, that can be pending this change. |
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jun 2, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
7 times, most recently
from
48e3d77 to
c611481
Compare
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jun 9, 2016
…riptors are not added. Per tc39/ecma262#593
|
Can this be merged? |
|
It needs consensus, so it's open until the next meeting. |
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
from
c611481 to
6cd67e1
Compare
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jun 15, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jun 16, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 2, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 2, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 2, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 2, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
from
6cd67e1 to
6b5d685
Compare
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 4, 2016
…riptors are not added. Per tc39/ecma262#593
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 4, 2016
…gOPDs Implements the change proposed at tc39/ecma262#593. In summary, Object.getOwnPropertyDescriptors can produce results which cause Object.defineProperties() to throw, by inserting a property with an undefined descriptor into the result object. This change to the algorithm requires that the descriptor only be added to the result object if it is not undefined. BUG=v8:4725 R=littledan@chromium.org, adamk@chromium.org, jwolfe@igalia.com Review-Url: https://codereview.chromium.org/2118613003 Cr-Commit-Position: refs/heads/master@{#37504}
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
from
6b5d685 to
316cf3a
Compare
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
from
316cf3a to
58fc6a0
Compare
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 18, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
from
58fc6a0 to
f76e9c6
Compare
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 26, 2016
…riptors are not added. Per tc39/ecma262#593
|
This received consensus at the July 2016 TC39 meeting; please merge at your leisure.
|
This was referenced Jul 26, 2016
ljharb
added a commit
to es-shims/Object.getOwnPropertyDescriptors
that referenced
this pull request
Jul 26, 2016
ljharb
added a commit
to es-shims/Object.getOwnPropertyDescriptors
that referenced
this pull request
Jul 26, 2016
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Jul 26, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to tc39/proposal-object-getownpropertydescriptors
that referenced
this pull request
Jul 27, 2016
ljharb
force-pushed
the
ljharb/gopds_bad_proxies
branch
from
f76e9c6 to
aaec801
Compare
bterlson
removed
the
needs consensus
|
Thank you sir! |
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Aug 1, 2016
…riptors are not added. Per tc39/ecma262#593
ljharb
added a commit
to ljharb/test262
that referenced
this pull request
Aug 1, 2016
…riptors are not added. Per tc39/ecma262#593
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Aug 1, 2016
…riptors are not added. (#662) Per tc39/ecma262#593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #582 (comment)
This needs TC39 consensus.