-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching Error in Chakra #3064
Comments
Self assigned due to looking at another bug hitting the same assert at the moment. |
suwc
pushed a commit
to suwc/ChakraCore
that referenced
this issue
Jul 25, 2017
…cess Accesses to super properties are cached on 'this' object (vs. the "super" object), causing conflict between e.g. super.x and this.x. Similar conflicts cause Issue#3423 for GetProperty cases. Fix by adding 'isSuper' flag to use appropriate object for caching. Fixes chakra-core#3064, chakra-core#3423
chakrabot
pushed a commit
that referenced
this issue
Aug 11, 2017
…operty access Merge pull request #3336 from suwc:build/suwc/Issue3064 Accesses to super properties are cached on 'this' object (vs. the "super" object), causing conflict between e.g. super.x and this.x. Similar conflicts cause Issue#3423 for GetProperty cases. Fix by adding 'isSuper' flag to use appropriate object for caching. Fixes #3064, Fixes #3423
chakrabot
pushed a commit
that referenced
this issue
Aug 11, 2017
…n super property access Merge pull request #3336 from suwc:build/suwc/Issue3064 Accesses to super properties are cached on 'this' object (vs. the "super" object), causing conflict between e.g. super.x and this.x. Similar conflicts cause Issue#3423 for GetProperty cases. Fix by adding 'isSuper' flag to use appropriate object for caching. Fixes #3064, Fixes #3423
chakrabot
pushed a commit
that referenced
this issue
Aug 11, 2017
…e conflicts in super property access Merge pull request #3336 from suwc:build/suwc/Issue3064 Accesses to super properties are cached on 'this' object (vs. the "super" object), causing conflict between e.g. super.x and this.x. Similar conflicts cause Issue#3423 for GetProperty cases. Fix by adding 'isSuper' flag to use appropriate object for caching. Fixes #3064, Fixes #3423
agarwal-sandeep
added a commit
to agarwal-sandeep/ChakraCore
that referenced
this issue
Oct 10, 2017
…g patterns. Due to a bug in super property access we were reaching the code path where we had src2 on instrcution but didn't freed it before generating bailout. After the fix for issue chakra-core#3423/chakra-core#3064 went in 2b9da66 the bu no longer reproes but for previous branches I am putting a conservative fix to always free src2 if we have it and don't have src1. For RS4 we have a WI to add asserts to better track no. of surces on instruction and add checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following code behaves incorrectly (inconsistent with the standard and other engines) in Chakra due to a missing cache update:
It should print 27 as the value of Derived.x, but instead prints 15. This code hits an assert in the debug build:
ASSERTION 5639: (/home/user/test_everywhere/ChakraCore/lib/Runtime/Types/TypePropertyCache.cpp, line 277) *propertyValue == JavascriptOperators::GetProperty(propertyObject, propertyId, requestContext)
Failure: (*propertyValue == JavascriptOperators::GetProperty(propertyObject, propertyId, requestContext))
Illegal instruction (core dumped)
The text was updated successfully, but these errors were encountered: