Skip to content

Conversation

@kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Feb 17, 2018

Backporting the HostPromiseRejection change to release/1.9

Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

1. Internal CC machinary for unhandled promise rejection.
2. Simplisitic implimentation in ch
3. Test case
@chakrabot chakrabot merged commit d36457c into chakra-core:release/1.9 Feb 20, 2018
chakrabot pushed a commit that referenced this pull request Feb 20, 2018
Merge pull request #4697 from kfarnung:promisereject

Backporting the HostPromiseRejection change to release/1.9
@kfarnung kfarnung deleted the promisereject branch February 20, 2018 18:55
@kfarnung
Copy link
Contributor Author

Thanks again @rhuanjl!

chakrabot pushed a commit that referenced this pull request Feb 20, 2018
Merge pull request #4697 from kfarnung:promisereject

Backporting the HostPromiseRejection change to release/1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants