Only do float type specialization if both sources are number #5717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatd
approved these changes
Sep 20, 2018
jackhorton
reviewed
Sep 21, 2018
nhat-nguyen
force-pushed
the
floattypespecfix
branch
from
db3d338 to
1c3ea7e
Compare
yullin-ms
pushed a commit
to yullin-ms/ChakraCore
that referenced
this pull request
Sep 22, 2018
…on if both sources are number Merge pull request chakra-core#5717 from nhat-nguyen:floattypespecfix Fix a bug where we try to type specialize non-numbers to floats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where we try to type specialize non-numbers to floats