Skip to content

Only do float type specialization if both sources are number #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhat-nguyen wants to merge 4 commits into from
Closed

Only do float type specialization if both sources are number #5717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa354bf
Only do float type specialization if both sources are number
nhat-nguyen Sep 20, 2018
e6bf150
Add bug test case
nhat-nguyen Sep 20, 2018
1c3ea7e
More descriptive name for test
nhat-nguyen Sep 21, 2018
d63bbba
Merge branch 'master' into floattypespecfix
nhat-nguyen Sep 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Backend/GlobOpt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10648,6 +10648,11 @@ GlobOpt::TypeSpecializeFloatBinary(IR::Instr *instr, Value *src1Val, Value *src2
case Js::OpCode::CmGe_A:
case Js::OpCode::CmGt_A:
{
if (src1Val->GetValueInfo()->IsNotNumber() || src2Val->GetValueInfo()->IsNotNumber())
{
return false;
}

convertDstToBool = true;
break;
}
Expand Down
17 changes: 17 additions & 0 deletions test/Basics/FloatComparison.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,23 @@ var tests = [
assert.isFalse({} < 0.5);
assert.isFalse({} <= 0.5);
}
},
{
name: "No float type specialization when operands are not number",
body: function() {
function test0() {
var func2 = function () {
return f32[1];
};
var f32 = new Float32Array();
var f = 100;
for (let i = 0; i < f; i++) {
var id41 = 'caller';
({ 18: func2() === 'caller' });
}
}
test0();
}
}
];

Expand Down