Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When terminals are declared as "dumb", it means the author doesn't want/expect anything other than plain-text output. There's usually a damn good reason for this — we should treat
TERM=dumb
as meaningFORCE_COLOR=0
, instead of imagining this.Fixes:
chalk/supports-color#88
Related:
mochajs/mocha#1304
,emacs.stackexchange.com/q/27218
Emacs
compile
command — Before and after:@plroebuck As you can see, it seems some changes are still required elsewhere to clean up the stack-trace highlighting.
This fix has the unfortunate effect of impacting Emacs commands which do colourise output directly, such as
mocha.el
's(mocha-test-project)
command:mocha.el
— Before and after:Authors can always fix this by forcing colours in their environments, though, so this shouldn't be a problem in the long-run.