Add FORCE_COLOR=1
to default environment variables
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cut a long story short, Mocha's coloured output is causing Emacs users grief because Emac's default
compile
command chokes on ANSI escape sequences when emitted frommake -k
feedback. @plroebuck identified the crux of the problem inchalk/supports-color
handling ofTERM=dumb
environments.I submitted a pull-request which fixes this, and simultaneously fixes
compiler-mode
's problems whilst affecting the coloured output ofmocha.el
:Basically, the fix is to add
FORCE_COLOR=1
in the environment, which is picked up by thesupports-color
module as a user's wish to go and use coloured output anyway, irrespective o f theTERM=dumb
variable being set in both compiler-modes.We can merge this now, it won't get noticed because the package's highlighting is currently working fine. But users will notice once
chalk/supports-color#89
gets merged and shipped in a new release; having this the default formocha-environment-variables
ensures there's absolutely no friction when it does. =)