Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable commit signing #126

Closed
jackleslie opened this issue Dec 16, 2021 · 2 comments · Fixed by #131
Closed

Add option to enable commit signing #126

jackleslie opened this issue Dec 16, 2021 · 2 comments · Fixed by #131

Comments

@jackleslie
Copy link
Contributor

Context

At the moment, if you use this action and have the Require signed commits setting enabled for a protected branch, the PR generated can't be merged.

Example

Crowdin, a popular localisation management tool, has a similar action which opens a PR using a bot.

They allow you to pass a gpg_private_key as a config option, which will enable signed commits for the bot opening the PR. See options here.

@Andarist
Copy link
Member

Sure, if you want to implement this - I would gladly review and merge a PR for this. For reference - this is what they do based on the gpg_private_key input:
https://github.com/crowdin/github-action/blob/b9b3c18f523d40926d75e48fc7fd2b6fdc23caee/entrypoint.sh#L174-L193

@jackleslie
Copy link
Contributor Author

@Andarist opened a PR, let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants