-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom git user input option #131
Conversation
🦋 Changeset detectedLatest commit: f4b970b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Andarist @mitchellhamilton just bumping this if that's okay Would you prefer this approach or the one in #127? |
@jacklesliewise the only concern I have with this PR is the nit about the name that has been chosen for the option. I think this might be useful to some people in other situations than the one covered by #127 so this should land either way (regardless of what we decide for the #127 but most likely we'll close it, for the time being, we can always revisit this in the future). |
Context
Fixes #126, alternative solution to #127
Instead of implementing git commit signing into the action, we could allow an input option to disable the
setupUser
function so that consumers can use their own git user to create commits in this action.Changes
setupGitUser
boolean input option@actions/core
to be able to usegetBooleanInput
true
gitUtils.setupUser()
ifsetupGitUser
isfalse