Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for GPG signing without manually configuring keys #392

Open
s0 opened this issue Aug 25, 2024 · 0 comments · May be fixed by #391
Open

Allow for GPG signing without manually configuring keys #392

s0 opened this issue Aug 25, 2024 · 0 comments · May be fixed by #391

Comments

@s0
Copy link
Contributor

s0 commented Aug 25, 2024

This follows on from #126, #127, #131.

Firstly, I'd just like to say I love changesets 🦋! Thanks for putting together such a great project.

Recently I found myself using this action, and facing some difficulties around branch protection / repo rulesets that require signed commits, and the default behavior of the action when it comes to creating the "Version packages" PRs.

My options were either to:

  1. rebase / amend every PR created to bump versions manually, so that the commits are signed
  2. Register a new GitHub User, generate a GPG key for it, generate a personal access token for it, provision access to the repository, add the private key and token as secrets, and update the GitHub workflow to configure git and GPG appropriately.
  3. Update the action to use GitHub's API to create changes, which is signed by default by GitHub's internal GPG key, and works with both user tokens and app tokens (i.e. GitHub Actions). See: https://github.com/s0/ghcommit?tab=readme-ov-file#why

Given that (1) is a lot of manual work per release (no longer can you just release using GitHub's UI), and (2) would be a considerable amount of setup, with the added risk of secret exposure, it probably makes most sense to implement (3).

@s0 s0 linked a pull request Aug 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant