fix: table hover state #1300

codemonkey800 · 2024-11-04T20:23:04Z

Fixes table link hover state to show darker color when hovering over the link or row
Adds caret that shows next to the link on hover

Demo

kev-zunshiwang · 2024-11-05T22:06:08Z

Looks great!

kne42 · 2024-11-05T23:11:02Z

frontend/packages/data-portal/app/components/Table/TableLink.tsx

+      <span
+        className={cns(
+          'hidden group-hover:inline-flex',
+          '[&_svg]:text-sds-color-semantic-text-action-hover',


tailwind appreciation post

🤖 I have created a release *beep* *boop* --- ## [1.36.0](web-v1.35.1...web-v1.36.0) (2024-11-06) ### ✨ Features * challenge status banner ([#1319](#1319)) ([1bd0bff](1bd0bff)) * definition and search updates ([#1298](#1298)) ([58e36ea](58e36ea)) * ML challenge launch copy updates ([#1318](#1318)) ([7ceff67](7ceff67)) * order datasets by release date ([#1320](#1320)) ([788c178](788c178)) * universal empty states ([#1295](#1295)) ([ef64faa](ef64faa)) ### 🐞 Bug Fixes * download code snippets ([#1315](#1315)) ([b137eb4](b137eb4)) * fix single run page view tomogram button ([#1325](#1325)) ([da6902c](da6902c)) * fix view tomogram button greyed out error ([#1323](#1323)) ([5a6ca7a](5a6ca7a)) * table hover state ([#1300](#1300)) ([800ad33](800ad33)) ### 🧹 Miscellaneous Chores * fix ml challenge page nits ([#1324](#1324)) ([9ba9fa7](9ba9fa7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

codemonkey800 added 2 commits November 4, 2024 12:16

fix table group hover

c3394d3

show caret on clickable rows

badf6ca

codemonkey800 requested review from tihuan, kne42, ehoops-cz and bchu1 November 4, 2024 20:23

codemonkey800 temporarily deployed to local November 4, 2024 20:23 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local November 4, 2024 20:27 — with GitHub Actions Error

codemonkey800 had a problem deploying to local November 4, 2024 20:27 — with GitHub Actions Failure

codemonkey800 had a problem deploying to local November 4, 2024 20:27 — with GitHub Actions Error

codemonkey800 temporarily deployed to dev November 4, 2024 20:40 — with GitHub Actions Inactive

codemonkey800 temporarily deployed to local November 4, 2024 20:41 — with GitHub Actions Inactive

ehoops-cz approved these changes Nov 5, 2024

View reviewed changes

kne42 approved these changes Nov 5, 2024

View reviewed changes

codemonkey800 merged commit 800ad33 into main Nov 5, 2024
14 of 15 checks passed

codemonkey800 deleted the jeremy/fix-table-hover-state branch November 5, 2024 23:42

github-actions bot mentioned this pull request Nov 5, 2024

chore(main): release web 1.36.0 #1311

Merged