fix: update deploy docs for storybook 7.x #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booc0mtaco
force-pushed
the
aholloway/x-fix-gh-pages-deploy
branch
from
e583c5e
to
010d91b
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1733 +/- ##
==========================================
- Coverage 92.32% 92.28% -0.04%
==========================================
Files 146 146
Lines 2579 2579
Branches 665 665
==========================================
- Hits 2381 2380 -1
Misses 183 183
- Partials 15 16 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
booc0mtaco
force-pushed
the
aholloway/x-fix-gh-pages-deploy
branch
5 times, most recently
from
a8e098d
to
a8d65d5
Compare
|
Note: completed publish of v13.1.0 since this fix also did a docs deploy of what's on |
ahuth
approved these changes
Aug 23, 2023
booc0mtaco
commented
Aug 23, 2023
| - name: Deploy Storybook | ||
| uses: peaceiris/actions-gh-pages@v3 | ||
| with: | ||
| publish_dir: ./storybook-static |
There was a problem hiding this comment.
the naming is a bit awkward here... this should be read as dir_to_publish or similar; this isn't where the docs will be published to, and won't end up in the path
booc0mtaco
force-pushed
the
aholloway/x-fix-gh-pages-deploy
branch
from
788b248
to
d80ed06
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ref: storybookjs/storybook#20932
Test Plan: