feat(Accordion): allow empty or hidden accordion rows #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
booc0mtaco
added
the
do not merge
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1767 +/- ##
==========================================
+ Coverage 92.24% 92.27% +0.02%
==========================================
Files 146 146
Lines 2606 2615 +9
Branches 681 687 +6
==========================================
+ Hits 2404 2413 +9
Misses 186 186
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
TBD:
|
booc0mtaco
removed
the
do not merge
booc0mtaco
force-pushed
the
aholloway/EFI-1360
branch
from
4cb254c
to
a481f2c
Compare
ahuth
reviewed
Sep 29, 2023
ahuth
reviewed
Sep 29, 2023
| ); | ||
| const accordionButton = screen.getByTestId('accordion-button'); | ||
|
|
||
| await act(async () => { |
There was a problem hiding this comment.
Does anything bad happen if we remove the act?
user.click is supposed to have that baked into it.
There was a problem hiding this comment.
it generates a gross warning when act() is not present:
Warning: An update to DisclosureFn inside a test was not wrapped in act(...).
When testing, code that causes React state updates should be wrapped into act(...):
act(() => {
/* fire events that update state */
});
/* assert on the output */
ahuth
approved these changes
Sep 29, 2023
booc0mtaco
force-pushed
the
aholloway/EFI-1360
branch
from
a481f2c
to
796e29e
Compare
- adding an 'isExpandable' set to falsewill hide the features that afford clicking - add tests to verify this behavior - add new snapshots
booc0mtaco
force-pushed
the
aholloway/EFI-1360
branch
from
796e29e
to
e459f9b
Compare
Merged
booc0mtaco
added a commit
that referenced
this pull request
Oct 4, 2023
## [13.4.0](v13.3.0...v13.4.0) (2023-10-03) ### Features * **Accordion:** allow empty or hidden accordion rows ([#1767](#1767)) ([e044a85](e044a85)) * **Icons:** allow component icon usages to be headless ([#1761](#1761)) ([ba454bf](ba454bf)) * **InputField:** support recommendedMaxLength prop for display-only errors ([#1771](#1771)) ([cc84a20](cc84a20)) * **Tabs:** add ability to customize tab button headers ([#1768](#1768)) ([f231ad4](f231ad4)) * **TextareaField:** support recommendedMaxLength prop for display-only errors ([#1769](#1769)) ([0852356](0852356))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
isExpandable={false}to anAccordianRowwill hide the feature that afford clickingTest Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.