feat(InputField): support recommendedMaxLength prop for display-only errors #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1771 +/- ##
==========================================
+ Coverage 92.29% 92.35% +0.06%
==========================================
Files 146 147 +1
Lines 2635 2656 +21
Branches 697 711 +14
==========================================
+ Hits 2432 2453 +21
Misses 187 187
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
booc0mtaco
force-pushed
the
aholloway/EFI-1381
branch
from
2ef640e
to
44715bb
Compare
|
booc0mtaco
force-pushed
the
aholloway/EFI-1381
branch
from
44715bb
to
ff085ef
Compare
booc0mtaco
added
the
do not merge
booc0mtaco
force-pushed
the
aholloway/EFI-1381
branch
from
ff085ef
to
b73aaa9
Compare
ahuth
reviewed
Oct 2, 2023
ahuth
reviewed
Oct 2, 2023
Comment on lines
+191
to
+192
| const textExceedsMaxLength = | ||
| maxLength !== undefined && fieldLength ? fieldLength > maxLength : false; |
There was a problem hiding this comment.
Nit, couple ideas:
const fieldLength = fieldText?.toString().length ?? 0;
const textExceedsMaxLength = maxLength && fieldLength > maxLength;or give maxLength a default and simplifyt the check even more
maxLength = Infinity
...
const textExceedsMaxLength = fieldLength > maxLength;There was a problem hiding this comment.
Will apply a few things where possible. One thing I wanted to avoid were any props being added if the consumer didn't specify them. maxLength is also weird in that it changes how the base field behaves when it has a value, and it treats Infinity as invalid if it gets to <textarea>
ahuth
reviewed
Oct 2, 2023
| ); | ||
|
|
||
| // Pick the smallest of the lengths to set as the maximum value allowed | ||
| const maxLengthShown = getMinValue(maxLength, recommendedMaxLength); |
There was a problem hiding this comment.
If maxLength and recommendedMaxLength are numbers (e.g. if they have default values or fallbacks), may be able to use Math.min?
ahuth
approved these changes
Oct 3, 2023
4 tasks
…errors - allow handling for maxlength and recommendedMaxLength like TextareaField - add utility method for finding smallest value - update snapshots and tests
booc0mtaco
force-pushed
the
aholloway/EFI-1381
branch
from
b73aaa9
to
612bad2
Compare
booc0mtaco
removed
the
do not merge
size-limit report 📦
|
Merged
booc0mtaco
added a commit
that referenced
this pull request
Oct 4, 2023
## [13.4.0](v13.3.0...v13.4.0) (2023-10-03) ### Features * **Accordion:** allow empty or hidden accordion rows ([#1767](#1767)) ([e044a85](e044a85)) * **Icons:** allow component icon usages to be headless ([#1761](#1761)) ([ba454bf](ba454bf)) * **InputField:** support recommendedMaxLength prop for display-only errors ([#1771](#1771)) ([cc84a20](cc84a20)) * **Tabs:** add ability to customize tab button headers ([#1768](#1768)) ([f231ad4](f231ad4)) * **TextareaField:** support recommendedMaxLength prop for display-only errors ([#1769](#1769)) ([0852356](0852356))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
maxlengthandrecommendedMaxLengthlike TextareaFieldTest Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.