feat(TextareaField): support recommendedMaxLength prop for display-only errors #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBD:
|
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1769 +/- ##
==========================================
- Coverage 92.29% 92.29% -0.01%
==========================================
Files 146 146
Lines 2623 2635 +12
Branches 690 697 +7
==========================================
+ Hits 2421 2432 +11
Misses 187 187
- Partials 15 16 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Screen.Recording.2023-09-29.at.18.14.37.mov |
booc0mtaco
force-pushed
the
aholloway/EFI-1382
branch
from
bc1f6c6
to
9e43020
Compare
…ly errors - new prop allows for showing an error but letting the user continue typing content - maxLength still works, and can be a different (larger or equal) value - update snapshots - add tests
booc0mtaco
force-pushed
the
aholloway/EFI-1382
branch
from
9e43020
to
9dc9bf2
Compare
ahuth
reviewed
Oct 3, 2023
Comment on lines
+124
to
+132
| function getSmallest(lengthA?: number, lengthB?: number): number | undefined { | ||
| if (lengthA !== undefined && lengthB !== undefined) { | ||
| return Math.min(lengthA, lengthB); | ||
| } else if (lengthA && lengthB === undefined) { | ||
| return lengthA; | ||
| } else if (lengthB && lengthA === undefined) { | ||
| return lengthB; | ||
| } | ||
| } |
There was a problem hiding this comment.
Code golf time 🏌️♀️
Suggested change
| function getSmallest(lengthA?: number, lengthB?: number): number | undefined { | |
| if (lengthA !== undefined && lengthB !== undefined) { | |
| return Math.min(lengthA, lengthB); | |
| } else if (lengthA && lengthB === undefined) { | |
| return lengthA; | |
| } else if (lengthB && lengthA === undefined) { | |
| return lengthB; | |
| } | |
| } | |
| function getSmallest(...args: Array<number | undefined>): number | undefined { | |
| if (args.length === 0) { | |
| return; | |
| } | |
| return Math.min(...args.filter(Boolean) as number[]); | |
| } |
or with type predicate on the filter:
Suggested change
| function getSmallest(lengthA?: number, lengthB?: number): number | undefined { | |
| if (lengthA !== undefined && lengthB !== undefined) { | |
| return Math.min(lengthA, lengthB); | |
| } else if (lengthA && lengthB === undefined) { | |
| return lengthA; | |
| } else if (lengthB && lengthA === undefined) { | |
| return lengthB; | |
| } | |
| } | |
| function getSmallest(...args: Array<number | undefined>): number | undefined { | |
| if (args.length === 0) { | |
| return; | |
| } | |
| return Math.min(...args.filter((n): n is number => Boolean(n))); | |
| } |
There was a problem hiding this comment.
I like these ⛳! Since the other PR builds upon this one and moves this into a utility, will commit this as-is, and take some strokes off in #1771
ahuth
approved these changes
Oct 3, 2023
Merged
booc0mtaco
added a commit
that referenced
this pull request
Oct 4, 2023
## [13.4.0](v13.3.0...v13.4.0) (2023-10-03) ### Features * **Accordion:** allow empty or hidden accordion rows ([#1767](#1767)) ([e044a85](e044a85)) * **Icons:** allow component icon usages to be headless ([#1761](#1761)) ([ba454bf](ba454bf)) * **InputField:** support recommendedMaxLength prop for display-only errors ([#1771](#1771)) ([cc84a20](cc84a20)) * **Tabs:** add ability to customize tab button headers ([#1768](#1768)) ([f231ad4](f231ad4)) * **TextareaField:** support recommendedMaxLength prop for display-only errors ([#1769](#1769)) ([0852356](0852356))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
recommendedLengthallows for showing an error but letting the user continue typing contentmaxLengthstill works, and can be a different (larger or equal) valueTest Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.