Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(link)!: remove text-link tokens for link t3 tokens #1639

Merged
merged 10 commits into from
Aug 14, 2023

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented May 26, 2023

EDS-1009

Summary:

  • removes text-link tokens since link now has t3 tokens

Test Plan:

  • CI tests / new tests are not applicable
    • no visual regressions

@jinlee93 jinlee93 requested a review from a team May 26, 2023 20:33
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1639 (4faffa5) into next (569481a) will decrease coverage by 0.02%.
Report is 13 commits behind head on next.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #1639      +/-   ##
==========================================
- Coverage   92.58%   92.57%   -0.02%     
==========================================
  Files         155      155              
  Lines        2766     2762       -4     
  Branches      725      724       -1     
==========================================
- Hits         2561     2557       -4     
- Misses        188      203      +15     
+ Partials       17        2      -15     
Files Changed Coverage Δ
src/tokens-dist/ts/colors.ts 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco booc0mtaco added the next-major PRs to hold until the next major version (should include codemod) label May 26, 2023
Base automatically changed from jlee/linkt3tokens to next May 30, 2023 19:29
@github-actions
Copy link

github-actions bot commented Jul 26, 2023

size-limit report 📦

Path Size
components 95.49 KB (0%)
styles 32.68 KB (-0.27% 🔽)

@jinlee93 jinlee93 changed the title refactor(link)!: point t3 to t1 tokens refactor(link)!: remove text-link tokens for link t3 tokens Jul 26, 2023
@jinlee93 jinlee93 marked this pull request as ready for review July 26, 2023 01:26
Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, although am i missing something? no files in design-tokens have changed, so how were these tokens in variables-nest.json?

@jinlee93
Copy link
Contributor Author

this looks good, although am i missing something? no files in design-tokens have changed, so how were these tokens in variables-nest.json?

The tokens were added back in their respective json files during a rebase, re-removed them and re-pushed

@booc0mtaco
Copy link
Contributor

@jinlee93 ah makes sense now

@jinlee93
Copy link
Contributor Author

I'm gonna hold off on this one since it seems to need some sync

@booc0mtaco
Copy link
Contributor

Cleaning up existing tokens that were already marked as deprecated. Should be safe to remove

@booc0mtaco booc0mtaco merged commit d35cfe4 into next Aug 14, 2023
6 checks passed
@booc0mtaco booc0mtaco deleted the jlee/linkt3tot1 branch August 14, 2023 21:06
@booc0mtaco booc0mtaco mentioned this pull request Aug 14, 2023
booc0mtaco added a commit that referenced this pull request Aug 15, 2023
## [13.0.0](v12.4.2...v13.0.0) (2023-08-14)


### ⚠ BREAKING CHANGES

* **link:** remove text-link tokens for link t3 tokens (#1639)
* **colors:** remove old colors and convert to input and show figma token (#1711)
* remove deprecated dropdown (#1657)
* **banner:** remove component (#1702)
* remove legacy tokens and typography mixins (#1709)
* **Grid:** remove top-level sub-component(s) (#1703)
* **dragdrop:** remove top level subcomponents (#1697)
* **Fieldset:** remove top-level sub-component(s) (#1695)
* **HorizontalStepper:** remove top-level sub-component(s) (#1696)
* **Card:** remove top-level sub-component(s) (#1692)
* **checkbox:** remove top level subcomponents (#1693)
* **radio:** remove top level subcomponents (#1690)
* **DataBar:** remove top-level sub-component(s) (#1686)
* **Modal:** remove top-level sub-component(s) (#1689)
* **searchbar:** remove top level subcomponents (#1687)
* **table:** remove top-level sub-components (#1685)
* **toolbar:** remove component (#1683)
* **Breadcrumbs:** remove top-level sub-component (#1680)
* **timelinenav:** remove top-level sub-component (#1681)

### Features

* **Breadcrumbs:** remove top-level sub-component ([#1680](#1680)) ([669081d](669081d))
* **Card:** remove top-level sub-component(s) ([#1692](#1692)) ([7ec01f4](7ec01f4))
* **checkbox:** remove top level subcomponents ([#1693](#1693)) ([87b12e8](87b12e8))
* **DataBar:** remove top-level sub-component(s) ([#1686](#1686)) ([b4b9276](b4b9276))
* **dragdrop:** remove top level subcomponents ([#1697](#1697)) ([b4fd00c](b4fd00c))
* **Fieldset:** remove top-level sub-component(s) ([#1695](#1695)) ([0c8280d](0c8280d))
* **Grid:** remove top-level sub-component(s) ([#1703](#1703)) ([c8925c9](c8925c9))
* **HorizontalStepper:** remove top-level sub-component(s) ([#1696](#1696)) ([188fd99](188fd99))
* **Layout:** mark layout components as deprecated ([#1700](#1700)) ([930a369](930a369))
* **Modal:** remove top-level sub-component(s) ([#1689](#1689)) ([8743e62](8743e62))
* **radio:** remove top level subcomponents ([#1690](#1690)) ([82da617](82da617))
* remove legacy tokens and typography mixins ([#1709](#1709)) ([ec3e819](ec3e819))
* **searchbar:** remove top level subcomponents ([#1687](#1687)) ([d13bb6c](d13bb6c))
* **table:** remove top-level sub-components ([#1685](#1685)) ([742a530](742a530))
* **timelinenav:** remove top-level sub-component ([#1681](#1681)) ([f46eca7](f46eca7))


### Bug Fixes

* **Avatar:** support display names using emoji and multi-byte ([#1716](#1716)) ([1294022](1294022))
* update token exports ([#1722](#1722)) ([982c55f](982c55f))


* **banner:** remove component ([#1702](#1702)) ([356550c](356550c))
* **colors:** remove old colors and convert to input and show figma token ([#1711](#1711)) ([c9a5079](c9a5079))
* **link:** remove text-link tokens for link t3 tokens ([#1639](#1639)) ([d35cfe4](d35cfe4))
* remove deprecated dropdown ([#1657](#1657)) ([26d1694](26d1694))
* **toolbar:** remove component ([#1683](#1683)) ([bd47899](bd47899))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-major PRs to hold until the next major version (should include codemod)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants