feat(radio)!: remove top level subcomponents #1690
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/EFI-1219 #1690 +/- ##
====================================================
- Coverage 93.04% 93.01% -0.03%
====================================================
Files 196 192 -4
Lines 2890 2878 -12
Branches 716 716
====================================================
- Hits 2689 2677 -12
Misses 184 184
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| margin: 0; | ||
| /* Remove the radio from the page flow, positioning it on top of the SVG. */ | ||
| position: absolute; | ||
| left: 0.25rem; |
There was a problem hiding this comment.
nit: this should be --eds-size-half i think but I'm guessing this was just brought over from the other file
| .radio__label--md { | ||
| top: 0.125rem; | ||
| } | ||
| .radio__label--lg { | ||
| top: 0.0625rem; | ||
| } |
There was a problem hiding this comment.
Not a fan of this, but again this was just brought over :)
There was a problem hiding this comment.
0.125rem corresponds to --eds-size-quarter which does exist, but --eds-size-eighth or what have you does not...and probably shouldn't. the sizes tokens are kinda weird. I wonder if there are other cases of such a small relative spacing that would indicate we should add this token?
There was a problem hiding this comment.
There are a some instances where 0.0625rem is used; still tho eighth is kind of small?
There was a problem hiding this comment.
I'll convert the instances of 0.25rem and 0.125rem to the size tokens and create a ticket to think about using eds-size-eighth if that's alright with you @booc0mtaco
There was a problem hiding this comment.
very small... one pixel in fact :/
This seems to exist to vertically center the text with the radio button. there may be a way to do the same via flex and avoid this kinda thing altogether. So as not to over-complicate this PR, we can make a comment on why such a precise value is being used, then leave it be for now
There was a problem hiding this comment.
That makes sense to me, will do
* feat(radio)!: remove top level subcomponents * refactor(radio): use size tokens
## [13.0.0](v12.4.2...v13.0.0) (2023-08-14) ### ⚠ BREAKING CHANGES * **link:** remove text-link tokens for link t3 tokens (#1639) * **colors:** remove old colors and convert to input and show figma token (#1711) * remove deprecated dropdown (#1657) * **banner:** remove component (#1702) * remove legacy tokens and typography mixins (#1709) * **Grid:** remove top-level sub-component(s) (#1703) * **dragdrop:** remove top level subcomponents (#1697) * **Fieldset:** remove top-level sub-component(s) (#1695) * **HorizontalStepper:** remove top-level sub-component(s) (#1696) * **Card:** remove top-level sub-component(s) (#1692) * **checkbox:** remove top level subcomponents (#1693) * **radio:** remove top level subcomponents (#1690) * **DataBar:** remove top-level sub-component(s) (#1686) * **Modal:** remove top-level sub-component(s) (#1689) * **searchbar:** remove top level subcomponents (#1687) * **table:** remove top-level sub-components (#1685) * **toolbar:** remove component (#1683) * **Breadcrumbs:** remove top-level sub-component (#1680) * **timelinenav:** remove top-level sub-component (#1681) ### Features * **Breadcrumbs:** remove top-level sub-component ([#1680](#1680)) ([669081d](669081d)) * **Card:** remove top-level sub-component(s) ([#1692](#1692)) ([7ec01f4](7ec01f4)) * **checkbox:** remove top level subcomponents ([#1693](#1693)) ([87b12e8](87b12e8)) * **DataBar:** remove top-level sub-component(s) ([#1686](#1686)) ([b4b9276](b4b9276)) * **dragdrop:** remove top level subcomponents ([#1697](#1697)) ([b4fd00c](b4fd00c)) * **Fieldset:** remove top-level sub-component(s) ([#1695](#1695)) ([0c8280d](0c8280d)) * **Grid:** remove top-level sub-component(s) ([#1703](#1703)) ([c8925c9](c8925c9)) * **HorizontalStepper:** remove top-level sub-component(s) ([#1696](#1696)) ([188fd99](188fd99)) * **Layout:** mark layout components as deprecated ([#1700](#1700)) ([930a369](930a369)) * **Modal:** remove top-level sub-component(s) ([#1689](#1689)) ([8743e62](8743e62)) * **radio:** remove top level subcomponents ([#1690](#1690)) ([82da617](82da617)) * remove legacy tokens and typography mixins ([#1709](#1709)) ([ec3e819](ec3e819)) * **searchbar:** remove top level subcomponents ([#1687](#1687)) ([d13bb6c](d13bb6c)) * **table:** remove top-level sub-components ([#1685](#1685)) ([742a530](742a530)) * **timelinenav:** remove top-level sub-component ([#1681](#1681)) ([f46eca7](f46eca7)) ### Bug Fixes * **Avatar:** support display names using emoji and multi-byte ([#1716](#1716)) ([1294022](1294022)) * update token exports ([#1722](#1722)) ([982c55f](982c55f)) * **banner:** remove component ([#1702](#1702)) ([356550c](356550c)) * **colors:** remove old colors and convert to input and show figma token ([#1711](#1711)) ([c9a5079](c9a5079)) * **link:** remove text-link tokens for link t3 tokens ([#1639](#1639)) ([d35cfe4](d35cfe4)) * remove deprecated dropdown ([#1657](#1657)) ([26d1694](26d1694)) * **toolbar:** remove component ([#1683](#1683)) ([bd47899](bd47899))
EFI-1231
Summary:
Test Plan: