Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics feature flag clean up #1181

Merged
merged 9 commits into from
Jul 31, 2023
Merged

Metrics feature flag clean up #1181

merged 9 commits into from
Jul 31, 2023

Conversation

manasaV3
Copy link
Collaborator

@manasaV3 manasaV3 commented Jul 28, 2023

Description

Relates to: #1178, #1179, #1180, #1069

Changes introduced:

@manasaV3 manasaV3 added the clean-up This references any clean up work that is needed post feature development label Jul 28, 2023
@manasaV3 manasaV3 added the maintenance Release Label: Used for categorizing maintenance PRs in automated CI release notes label Jul 28, 2023
@manasaV3 manasaV3 marked this pull request as ready for review July 28, 2023 17:43
@manasaV3 manasaV3 changed the title Metrics ff clean up Metrics feature flag clean up Jul 28, 2023
@manasaV3 manasaV3 requested review from codemonkey800, klai95 and richaagarwal and removed request for klai95 July 28, 2023 17:45
richaagarwal
richaagarwal previously approved these changes Jul 28, 2023
@@ -0,0 +1,70 @@
import logging
Copy link
Collaborator

@richaagarwal richaagarwal Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how organized this set of functions is now!

@manasaV3 manasaV3 requested a review from richaagarwal July 29, 2023 03:04
@manasaV3 manasaV3 merged commit 37eb7c8 into main Jul 31, 2023
@manasaV3 manasaV3 deleted the metrics-ff-clean-up branch July 31, 2023 19:34
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This PR has been included in release: v23.08.0, see the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up This references any clean up work that is needed post feature development maintenance Release Label: Used for categorizing maintenance PRs in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants