-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics feature flag clean up #1181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
added
the
clean-up
This references any clean up work that is needed post feature development
label
Jul 28, 2023
manasaV3
added
the
maintenance
Release Label: Used for categorizing maintenance PRs in automated CI release notes
label
Jul 28, 2023
manasaV3
requested review from
codemonkey800,
klai95 and
richaagarwal
and removed request for
klai95
July 28, 2023 17:45
richaagarwal
previously approved these changes
Jul 28, 2023
@@ -0,0 +1,70 @@ | |||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love how organized this set of functions is now!
richaagarwal
approved these changes
Jul 29, 2023
This PR has been included in release: v23.08.0, see the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clean-up
This references any clean up work that is needed post feature development
maintenance
Release Label: Used for categorizing maintenance PRs in automated CI release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to: #1178, #1179, #1180, #1069
Changes introduced:
use_dynamo_metric_maintenance
feature flag (Remove the dynamo feature flag for maintenance #1178)pyOpenSSL
as removing snowflake impacts the cryptography dependency version (Handle updates from dependabot for snowflake-connector-python #1069)