Metrics feature flag clean up

.happy/terraform/modules/cloudwatch-alarm/main.tf

@@ -71,20 +71,6 @@ resource aws_cloudwatch_log_metric_filter backend_plugin_update_successful {
   }
 }
 
-resource aws_cloudwatch_log_metric_filter backend_metrics_update_successful {
-  name            = "${var.stack_name}-backend-metrics-update-successful"
-  log_group_name  = var.backend_lambda_log_group_name
-  pattern         = "Completed data refresh for metrics successfully"
-  count           = var.metrics_enabled ? 1 : 0
-
-  metric_transformation {
-    name      = "${var.stack_name}-backend-metrics-update-successful"
-    namespace = local.metrics_namespace
-    value     = "1"
-    unit      = "Count"
-  }
-}
-
 resource aws_cloudwatch_log_metric_filter data_workflows_metrics_update_successful {
   name            = "${var.stack_name}-data-workflows-metrics-update-successful"
   log_group_name  = var.data_workflows_lambda_log_group_name
@@ -116,7 +102,6 @@ resource aws_cloudwatch_log_metric_filter data_workflows_plugin_update_successfu
 locals {
   backend_api_500_log_metric_name = var.metrics_enabled ? aws_cloudwatch_log_metric_filter.backend_api_500_log_metric[0].name : "backend_api_500_log_metric"
   backend_plugin_update_successful_name = var.metrics_enabled ? aws_cloudwatch_log_metric_filter.backend_plugin_update_successful[0].name : "backend_plugin_update_successful"
-  backend_metrics_update_successful_name = var.metrics_enabled ? aws_cloudwatch_log_metric_filter.backend_metrics_update_successful[0].name : "backend_metrics_update_successful"
   data_workflows_metrics_update_successful_name = var.metrics_enabled ? aws_cloudwatch_log_metric_filter.data_workflows_metrics_update_successful[0].name : "data_workflows_metrics_update_successful"
   data_workflows_plugin_update_successful_name = var.metrics_enabled ? aws_cloudwatch_log_metric_filter.data_workflows_plugin_update_successful[0].name : "data_workflows_plugin_update_successful"
 }
@@ -180,26 +165,6 @@ module data_workflow_plugins_missing_update_alarm {
   treat_missing_data  = "breaching"
 }
 
-module backend_metrics_missing_update_alarm {
-  source  = "terraform-aws-modules/cloudwatch/aws//modules/metric-alarm"
-  version = "3.3.0"
-
-  alarm_actions       = [local.alarm_sns_arn]
-  alarm_name          = "${var.stack_name}-backend-metrics-missing-update-alarm"
-  alarm_description   = "Metrics update failure for backend"
-  comparison_operator = "LessThanThreshold"
-  create_metric_alarm = var.alarms_enabled
-  datapoints_to_alarm = 1
-  evaluation_periods  = 1
-  metric_name         = local.backend_metrics_update_successful_name
-  namespace           = local.metrics_namespace
-  period              = 86400
-  statistic           = "Sum"
-  tags                = var.tags
-  threshold           = 1
-  treat_missing_data  = "breaching"
-}
-
 module data_workflows_metrics_missing_update_alarm {
   source  = "terraform-aws-modules/cloudwatch/aws//modules/metric-alarm"
   version = "3.3.0"

.happy/terraform/modules/ecs-stack/main.tf

@@ -285,8 +285,6 @@ module backend_lambda {
     "DD_SERVICE" = local.custom_stack_name
     "API_URL" = var.env == "dev" ? module.api_gateway_proxy_stage.invoke_url : ""
     "PLUGINS_LAMBDA_NAME" = local.plugins_function_name
-    "SNOWFLAKE_USER" = local.snowflake_user
-    "SNOWFLAKE_PASSWORD" = local.snowflake_password
     "API_KEY" = random_uuid.api_key.result
     "STACK_NAME" = local.custom_stack_name
   }
@@ -439,18 +437,6 @@ resource "aws_cloudwatch_event_rule" "activity_rule" {
   tags                = var.tags
 }
 
-resource "aws_cloudwatch_event_target" "activity_target" {
-    rule = aws_cloudwatch_event_rule.activity_rule.name
-    arn = module.backend_lambda.function_arn
-    input_transformer {
-        input_template = jsonencode({
-          path = "/activity/update",
-          httpMethod = "POST",
-          headers = {"X-API-Key": random_uuid.api_key.result}
-        })
-    }
-}
-
 resource aws_cloudwatch_event_target activity_target_sqs {
     rule = aws_cloudwatch_event_rule.activity_rule.name
     arn = aws_sqs_queue.data_workflows_queue.arn
@@ -469,10 +455,6 @@ locals {
       service    = "events"
       source_arn = aws_cloudwatch_event_rule.update_rule.arn
     },
-    AllowExecutionFromCloudWatchForActivity = {
-      service    = "events"
-      source_arn = aws_cloudwatch_event_rule.activity_rule.arn
-    }
   }
 }
 

backend/api/_tests/test_fixtures.py

@@ -1,12 +1,11 @@
-import pandas as pd
 from dateutil.relativedelta import relativedelta
-from datetime import datetime
+from datetime import datetime, date, timezone
 
-BASE = datetime.today().date().replace(day=1)
+BASE = datetime.combine(date.today(), datetime.min.time()).replace(day=1, tzinfo=timezone.utc)
 
 
 def _to_timestamp(i):
-    return int(pd.Timestamp(BASE + relativedelta(months=i)).timestamp()) * 1000
+    return int((BASE + relativedelta(months=i)).timestamp()) * 1000
 
 
 def _generate_timeline(start_range, value_key, to_value, timestamp_key='timestamp'):