Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: switch to Type=simple #13

Closed
Tracked by #74
garlick opened this issue Feb 29, 2016 · 1 comment · Fixed by #114
Closed
Tracked by #74

systemd: switch to Type=simple #13

garlick opened this issue Feb 29, 2016 · 1 comment · Fixed by #114

Comments

@garlick
Copy link
Member

garlick commented Feb 29, 2016

The recently added systemd unit files need an audit against fedora packaging guidelines

When systemctl stop powerman is run, a failure message is left in the journal that should be investigated.

Perhaps it would better to run powermand in non-forking Type=simple mode?
@garlick
Copy link
Member Author

garlick commented Feb 29, 2016

Not sure if the "failed state" when powerman is stopped indicates a problem with the way we are stopping powermand:

Feb 29 10:54:40 upgrade1 systemd[1]: Stopping PowerMan...
Feb 29 10:54:40 upgrade1 powermand[17353]: _pipe_disconnect(ipmi0):
/usr/sbin/ipmipower terminated with signal 15
Feb 29 10:54:40 upgrade1 powermand[17353]: exiting on signal 15
Feb 29 10:54:40 upgrade1 systemd[1]: powerman.service: main process exited,
code=exited, status=1/FAILURE
Feb 29 10:54:40 upgrade1 systemd[1]: Stopped PowerMan.
Feb 29 10:54:40 upgrade1 systemd[1]: Unit powerman.service entered failed state.
Feb 29 10:54:40 upgrade1 systemd[1]: powerman.service failed.

For symmetry, the journal output during start:

Feb 29 10:54:48 upgrade1 systemd[1]: Starting PowerMan...
Feb 29 10:54:48 upgrade1 powermand[21588]: started
Feb 29 10:54:48 upgrade1 powermand[21588]: _pipe_connect(ipmi0): opened on
/dev/pts/4
Feb 29 10:54:48 upgrade1 systemd[1]: Started PowerMan.

@garlick garlick mentioned this issue Mar 10, 2017
Merged
This was referenced Jan 23, 2024
Closed
Closed
@garlick garlick changed the title systemd unit files need audit systemd: switch to Type=simple Jan 23, 2024
garlick added a commit to garlick/powerman that referenced this issue Feb 2, 2024
@garlick
systemd: run as Type=simple
ed27e73 
Problem: powermand runs as a Type=forking systemd service,
but Type=simple is recommended by systemd.service(5).

Switch to Type=simple (the default).

Drop the tmpfiles.d configuration which was for managing
/run/powerman on systemd < v233 (now ancient).  Powerman doesn't
need the rundir anyway when not running in daemon mode, since all
it does is store a pidfile there.

Fixes chaos#13
garlick added a commit to garlick/powerman that referenced this issue Feb 2, 2024
@garlick
systemd: run as Type=simple
c0fe0f1 
Problem: powermand runs as a Type=forking systemd service,
but Type=simple is recommended by systemd.service(5).

Switch to Type=simple (the default).

Drop the tmpfiles.d configuration which was for managing
/run/powerman on systemd < v233 (now ancient).  Powerman doesn't
need the rundir anyway when not running in daemon mode, since all
it does is store a pidfile there.

Fixes chaos#13
@garlick garlick mentioned this issue Feb 2, 2024
Merged
garlick added a commit to garlick/powerman that referenced this issue Feb 3, 2024
@garlick
systemd: run as Type=simple
95e6e3e 
Problem: powermand runs as a Type=forking systemd service,
but Type=simple is recommended by systemd.service(5).

Switch to Type=simple (the default).

Drop the tmpfiles.d configuration which was for managing
/run/powerman on systemd < v233 (now ancient).  Powerman doesn't
need the rundir anyway when not running in daemon mode, since all
it does is store a pidfile there.

Fixes chaos#13
@mergify mergify bot closed this as completed in #114 Feb 3, 2024
chu11 pushed a commit to chu11/powerman that referenced this issue Apr 4, 2024
@garlick @chu11
systemd: run as Type=simple
731ac24 
Problem: powermand runs as a Type=forking systemd service,
but Type=simple is recommended by systemd.service(5).

Switch to Type=simple (the default).

Drop the tmpfiles.d configuration which was for managing
/run/powerman on systemd < v233 (now ancient).  Powerman doesn't
need the rundir anyway when not running in daemon mode, since all
it does is store a pidfile there.

Fixes chaos#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

systemd: run as Type=simple garlick/powerman
1 participant
@garlick