portability issues for EL 7.2

[brianjmurrell]

Systemd older than 233 doesn't support RuntimeDirectory*
directives and the accepted method for such releases is
to include a file in /usr/lib/tmpfiles.d to create the
[/var]/run/powerman directory.

[garlick]

Thanks Brian,

systemdtmpdir_ddir = /usr/lib/tmpfiles.d

should be ${prefix}/lib/tmpfiles.d?

[brianjmurrell]

should be ${prefix}/lib/tmpfiles.d?

Indeed. PR updated.

[brianjmurrell]

I didn't think making a PR for that second patch would actually add it to this PR.

I can try to separate them if desired.

That said, not sure why the check failed. make distcheck works here.

[garlick]

It's fine with me if these are in one PR.

Also fine if the spec remains a .in.

The travis failure needs attention. Maybe EXTRA_DIST needs to be updated?

[brianjmurrell]

Yeah. It was the EXTRA_DIST in the toplevel Makefile.am.

[garlick]

Sorry I didn't catch this earlier, but should RunttimeDirectory be removed from the unit file? Also should the tmpfiles path be substituted by configure to be ${localstatedir}/run?

[brianjmurrell]

I don't think it's supposed to be a problem to have both, particularly if they agree on what they are creating.

But I wonder if we should just remove them for now to be consistent with what the RHEL packagers are doing, which is not adding the RuntimeDirectory* directives but using tmpfiles.d files instead.

I'll push a new patch.

[brianjmurrell]

should the tmpfiles path be substituted by configure to be ${localstatedir}/run?

Do you mean the path inside the scripts/tmpfiles.d/powerman file which is currently:

+d /run/powerman   755 daemon daemon

So, on a given EL7 system I am looking at here, there are 7 each files in /usr/lib/tmpfiles.d/ that have (plain) /run as their path and /var/run as their path. So it seems to be pretty evenly divided about where /run is. Maybe the tie breaker is that /usr/lib/tmpfiles.d/systemd.conf itself is using /run and not /var/run.

[garlick]

I think the problem is that internally powerman uses:

char *rundir = hsprintf("%s/run/powerman", X_LOCALSTATEDIR);

So to match, the tmpdir really should substitute @X_LOCALSTATEDIR@/run/powerman

[garlick]

Feel free to add my proposed change for byacc from issue #22 to this PR (tagged with "Fixes #22").

Probably should change title of this PR to "Fix EL 7.2 portability issues" so the merge commit ends up with a good message too.

[garlick]

OK thanks for all this!

If you'll squash "tmpfiles" (b384c7a) with "package: older systemd systems need a tmpfiles.d file" (dc19cea) it will be ready to merge I think.

[brianjmurrell]

Oh yes. That squash was supposed to have happened. It failed due to a generated file that was going to be overwritten by the squash, or somesuch. Squashed and the PR updated.

[brianjmurrell]

Are these additions significant enough to make a new release? :-)

[garlick]

I'd kind of like to get #13 and #19 tackled first. (Feel free to pitch in on those if you like :-)