powerman: correct potential segfault #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Some old comments suggest looking "above" for code definitions. But that is out of date. Remove the "above" text and update comment.
|
argh ... i spoke too soon, this actually does remove the segfault but doesn't quite do what is expected. I realized I could reproduce this using the |
Problem: In _process_setresult() if the plug name is not found in the inputted arglist, it can result in a segfault. This can occur when power operations on dependent targets (e.g. the parent of node needs to be powered on) have errors, leading to an unexpected host having a "power result". Check that arg is non-NULL before trying to dereference it. Fixes chaos#197
Problem: If an error occurs on a parent, the error should not be output. It should only be output on the descendants that depend on the parent. Check the output_result flag before outputting error messages.
Problem: There are no tests for the special case where a parent results in a error and leads to a dependency error with the setresult statement. Add coverage via t0037-cray-ex.t.
chu11
force-pushed
the
issue197_segfault
branch
from
2dad0bb
to
b45e68f
Compare
|
ok, added 1) a fix in redfishpower that outputs an error message only for the intended target, not the parent B) added a test. Confirmed the test resulted in the segfault on master, fixed in this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In _process_setresult() if the plug name is not found in the inputted arglist, it can result in a segfault. This can occur when power operations on dependent targets (e.g. the parent of node needs to be powered on) have errors, leading to an unexpected host having a "power result".
Check that arg is non-NULL before trying to dereference it.
Fixes #197
side note, alternately those types of unexpected error messages could be removed from
redfishpower. I elected to leave those error messages. I figure for telemetry output and debugging, it can still be useful to output "severe error messages" (i.e. http error) on parents