Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerman: correct potential segfault #201

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Commits on Sep 9, 2024

  1. powerman: correct comment on code location

    Problem: Some old comments suggest looking "above" for code definitions.
    But that is out of date.
    
    Remove the "above" text and update comment.
    chu11 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ee88e78 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. powerman: correct potential segfault

    Problem: In _process_setresult() if the plug name is not found
    in the inputted arglist, it can result in a segfault.  This
    can occur when power operations on dependent targets (e.g. the
    parent of node needs to be powered on) have errors, leading to
    an unexpected host having a "power result".
    
    Check that arg is non-NULL before trying to dereference it.
    
    Fixes chaos#197
    chu11 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    dae192c View commit details
    Browse the repository at this point in the history
  2. redfishpower: do not output parent errors

    Problem: If an error occurs on a parent, the error should not
    be output.  It should only be output on the descendants that
    depend on the parent.
    
    Check the output_result flag before outputting error messages.
    chu11 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    33b948e View commit details
    Browse the repository at this point in the history
  3. t: cover parent failure on setresult

    Problem: There are no tests for the special case where a parent
    results in a error and leads to a dependency error with
    the setresult statement.
    
    Add coverage via t0037-cray-ex.t.
    chu11 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b45e68f View commit details
    Browse the repository at this point in the history