Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard module style guide #20392

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

mppf
Copy link
Member

@mppf mppf commented Aug 5, 2022

This PR updates StandardModuleStyle.rst per discussions in issues #14291 and #20240. We might change our mind about the capitalization rule but #20699 will add to this PR for that & it's reasonable to have the general guidance written down even if we are going to adjust it in the future.

Reviewed by @lydia-duncan and @daviditen - thanks!

---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
@mppf mppf requested review from daviditen and lydia-duncan August 5, 2022 16:29
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo but otherwise this looks good to me!

doc/rst/developer/bestPractices/StandardModuleStyle.rst Outdated Show resolved Hide resolved
Copy link
Member

@daviditen daviditen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
@mppf mppf force-pushed the update-standand-module-style-guide-fac branch from 9a9f446 to 4bacf19 Compare August 5, 2022 18:57
@mppf mppf merged commit 9ef3031 into chapel-lang:main Sep 26, 2022
@mppf mppf deleted the update-standand-module-style-guide-fac branch September 26, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants