list numPUs as an exeption to capitalization rule
#20699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
mppf
added a commit
that referenced
this pull request
Sep 26, 2022
…e-fac Update standard module style guide This PR updates StandardModuleStyle.rst per discussions in issues #14291 and #20240. We might change our mind about the capitalization rule but #20699 will add to this PR for that & it's reasonable to have the general guidance written down even if we are going to adjust it in the future. Reviewed by @lydia-duncan and @daviditen - thanks!
|
@jeremiah-corrado - I've just merged the other PR, FWIW. |
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
bradcray
reviewed
Sep 26, 2022
jeremiah-corrado
added a commit
that referenced
this pull request
Sep 27, 2022
Slight amendment to PR: #20699. Adds a statement explaining that we intend to update capitalization rules as more exceptions accumulate. [ Reviewed by @riftEmber ] - Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this poll: #20445 (comment), it was decided to list
locale.numPUsas an exception to the acronym capitalization convention discussed here: #20240.A new list of exceptions was started on the style-guide documentation page.
numPUsis currently the only entry.I used the convention description from this PR: #20392, which has not been merged yet.