Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeySpace KeyType is not handled #144

Closed
rosmanov opened this issue Apr 26, 2022 · 5 comments · Fixed by #161
Closed

KeySpace KeyType is not handled #144

rosmanov opened this issue Apr 26, 2022 · 5 comments · Fixed by #161
Assignees
@meowgorithm @bashbunni
Labels
bug Something isn't working

Comments

@rosmanov
Copy link

rosmanov commented Apr 26, 2022 •
edited
Loading

bubbletea has recently changed the KeyType for the space character.

As a result, in particular, nothing happens when the user enters space in the textinput component.

We need to add a case tea.KeySpace: somewhere around these lines.

bubbles revision is 292a1dd7ba97b1dc96a12d5ba50301cc731ef37f (current master)
@meowgorithm
Copy link
Member

Hi! @bashbunni just fixed this in charmbracelet/bubbletea#289. It will be available in the next release of Bubble Tea. If you need the functionality immediately you can pin to master.

Sorry for the confusion!

@meowgorithm
Copy link
Member

meowgorithm commented Apr 26, 2022 •
edited
Loading

Apologies, I completely misread this one. This is a very good catch. We'll correct this one shortly. Thank you for filing this.

@meowgorithm meowgorithm reopened this Apr 26, 2022
@meowgorithm meowgorithm added the bug Something isn't working label Apr 26, 2022
@bashbunni bashbunni self-assigned this May 5, 2022
@bashbunni bashbunni mentioned this issue May 6, 2022
Merged
2 tasks
@meowgorithm meowgorithm mentioned this issue May 13, 2022
Merged
@bashbunni
Copy link
Member

@meowgorithm let me know if this is still a wip but saw it was merged

@meowgorithm
Copy link
Member

meowgorithm commented May 23, 2022 •
edited
Loading

Merged in master on the Bubble Tea side, so we do need to make this change after all. Let’s get this one in a PR and queue it up to be merged right after the next Bubble Tea release.

@meowgorithm meowgorithm reopened this May 23, 2022
meowgorithm added a commit that referenced this issue May 29, 2022
@meowgorithm
fix(textinput): support keyspace in future Bubble Tea versions
28cca6e 
Closes #144
meowgorithm added a commit that referenced this issue May 29, 2022
@meowgorithm
fix(textinput): support KeySpace in future Bubble Tea versions
8dbd389 
Closes #144
meowgorithm added a commit that referenced this issue May 29, 2022
@meowgorithm
fix(textinput): support KeySpace in both present and future Bubble Te…
bb6583e 
…a versions

Closes #144
@meowgorithm meowgorithm mentioned this issue May 29, 2022
Merged
meowgorithm added a commit that referenced this issue May 29, 2022
@meowgorithm
fix(textinput): support KeySpace in both present and future Bubble Te…
a1e1b46 
…a versions

Closes #144
@meowgorithm
Copy link
Member

This is now fixed for both the present and the upcoming Bubble Tea versions.

ReallyLiri pushed a commit to ReallyLiri/bubbles that referenced this issue Jun 13, 2024
@meowgorithm
fix(textinput): support KeySpace in both present and future Bubble Te…
d9083cb 
…a versions

Closes charmbracelet#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meowgorithm meowgorithm

@bashbunni bashbunni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(textinput): support KeySpace in present and future Bubble Tea versions charmbracelet/bubbles
3 participants
@meowgorithm @rosmanov @bashbunni