change(keys): spacebar sends a KeySpace
#315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update reverts the hasty #311 and reimplements @bashbunni's excellent #289.
After further pondering we've decided it makes the most sense to make the following small change to the message produced by the spacebar after all:
Note that the
String()
method will still return" "
for backwards compatibility.The reasoning for this change is that binding things to the spacebar is common, but doing so in a "safe" manner is currently a bit cumbersome. Consider the following:
If course most of the time people simply:
So all-in-all this effectively is a minor change.
Also note that after this is released we'll need to address the issue in charmbracelet/bubbles#144 accordingly.