(v2) fix: windows: enable mouse mode on demand #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where mouse mode is always enabled on Windows. With this patch, we enable mouse events only it is requested. Needs: charmbracelet/x#386 Related: #1313
aymanbagabas
requested review from
meowgorithm,
caarlos0,
raphamorim and
andreynering
aymanbagabas
changed the title
Since mouse mode has a special case on Windows, we now have separate msg types for mouse events.
aymanbagabas
force-pushed
the
v2-mouse-mode
branch
from
6ddfdc3 to
838282d
Compare
andreynering
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where mouse mode is always enabled on Windows. With this patch, we enable mouse events only it is requested.
Needs: charmbracelet/x#386
Related: #1313