fix(input): windows: mouse mode flag #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
requested review from
meowgorithm,
caarlos0,
raphamorim and
andreynering
raphamorim
approved these changes
Feb 24, 2025
aymanbagabas
added a commit
to charmbracelet/bubbletea
that referenced
this pull request
Feb 24, 2025
This fixes an issue where mouse mode is always enabled on Windows. With this patch, we enable mouse events only it is requested. Needs: charmbracelet/x#386 Related: #1313
We need to enable mouse mode on Windows on demand. This is done by adding a new flag to the input driver and passing it to the cancelreader to enable mouse mode. Related: charmbracelet/bubbletea#1313
aymanbagabas
force-pushed
the
input/mouse-mode
branch
from
3bbc6f7 to
b3e8bec
Compare
andreynering
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to enable mouse mode on Windows on demand. This is done by adding a new flag to the input driver and passing it to the cancelreader to enable mouse mode.
Related: charmbracelet/bubbletea#1313