Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in tables broken #316

Closed
hughesjj opened this issue Nov 28, 2022 · 1 comment · Fixed by #317
Closed

Links in tables broken #316

hughesjj opened this issue Nov 28, 2022 · 1 comment · Fixed by #317
Assignees
Labels
bug Something isn't working

Comments

@hughesjj
Copy link

hughesjj commented Nov 28, 2022

Hey, none of the links in this repo under "Specification SIGs" or "Implementation SIGs" tables render properly via glow =(

They aren't clickable either.

https://github.com/open-telemetry/community/blob/main/README.md

image

@caarlos0
Copy link
Member

bug in glamour, transferring

@caarlos0 caarlos0 transferred this issue from charmbracelet/glow Jul 10, 2024
caarlos0 added a commit that referenced this issue Jul 17, 2024
caarlos0 added a commit that referenced this issue Jul 17, 2024
@caarlos0 caarlos0 self-assigned this Jul 17, 2024
@caarlos0 caarlos0 added the bug Something isn't working label Jul 17, 2024
bashbunni added a commit that referenced this issue Jul 31, 2024
* wip

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #290

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #312

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #257

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <bunni@bashbunni.dev>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: bashbunni <bunni@bashbunni.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants